Did you test the build locally? Usually there are a few new test failures that we have to add skips for on each version bump.

@Tyler-Hardin I tested the build on Darwin aarch64. And had no test failures.

I am currently waiting for nixpkgs-review-gha.

Sorry for multiple attempts, this is my first time trying to contribute to an existing package... and hopefully getting there.

You might be able to help me: what is the nix-commands way of expressing nix-build -A goose-cli on the cloned repo ?

See https://github.com/gotcha/nixpkgs-review-gha/actions/runs/18469810376

Sorry, missed your last comment. Here's what I use to test a package build inside the nixpkgs repo:

nix build .#packages.x86_64-linux.goose-cli

Thanks for your work on this. Looks good!

@fusion44 updated the PR for 1.10.2...

I'll run nixpkgs-review again.

1.10.2 has some auto generated new tests that result in names like:

    "--skip=test_replayed_session::vec_cargo_run_quiet_p_goose_server_bin_goosed_mcp_developer_vec_calltoolrequestparam_name_text_editor_into_arguments_some_object_command_view_path_goose_crates_goose_tests_tmp_goose_txt_calltoolrequestparam_name_text_editor_into_arguments_some_object_command_str_replace_path_goose_crates_goose_tests_tmp_goose_txt_old_str_goose_new_str_goose_modified_by_test_calltoolrequestparam_name_shell_into_arguments_some_object_command_cat_goose_crates_goose_tests_tmp_goose_txt_calltoolrequestparam_name_text_editor_into_arguments_some_object_command_str_replace_path_goose_crates_goose_tests_tmp_goose_txt_old_str_goose_modified_by_test_new_str_goose_calltoolrequestparam_name_list_windows_into_arguments_some_object_vec_expects"

Should I maybe patch out the whole file in the patch phase so we don't clutter the skip section in the script as much?

Edit - please don't merge yet. 1.10.2 contains a bug that should be fixed in next version:
block/goose#5202

Please squash commits.

Okay, package is updated to 1.11.0 and the error seems to be gone. Commits are squashed as requested.

https://github.com/gotcha/nixpkgs-review-gha/actions/runs/18620889054

FWIW, I added it via overlay and it works.

@gotcha, I think the maintainers/committers must be really busy getting the Nov release ready. You might already know this, but if not, here's how you can use your work locally now.

environment.systemPackages = with pkgs; [
  goose-cli.overrideAttrs (oldAddrs: rec {
    version = "...";                                  
    name = "${oldAttrs.pname}-${version}";
    src = oldAttrs.src.override {
      tag = "v${version}";
      hash = "...";
    };
 
    cargoDeps = rustPlatform.fetchCargoVendor {
      inherit src name;
      hash = "...";
    };
 
    checkFlags = (oldAttrs.checkFlags or []) ++ [
      ...
    ]; 
  })                                                  
];                                                    

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451624
Commit: 7942561d266ff47c34937bf6b2596d181b9225d5 (subsequent changes)
Merge: 4390ecbcb69bc06ad9172856ed0b29f8c151e855

Logs: https://github.com/yzx9/nixpkgs-review-gha/actions/runs/19190123217

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = relaxed)

aarch64-darwin (sandbox = relaxed)